Repository navigation
feat(conf): align flashsac g1_motion_tracking with sac and enforce same-dir base inheritance (ADR-0023) - #2614
Merged
Conversation
…me-dir base inheritance (ADR-0023) - Align the flashsac g1_motion_tracking owner with the SAC contract: canonical DR events, foot geom_names, and the biased actor joint observation; training budget already matched. The Newton owner keeps its historical DR-free behavior with events explicitly nulled. - Every task sim owner leaf now inherits only its same-directory base.yaml; cross-backend inheritance removed (sac/flashsac/appo/ppo g1_motion_tracking, ppo go2_joystick_flat/superdex). Shared DR and training budgets move into base.yaml; leaves carry their full task_name/sim_backend identity. - Add ADR-0023 and a structural guard test; composed configs verified key-identical before/after except the flashsac alignment itself. Training behavior: unchanged except flashsac g1_motion_tracking aligning to the SAC owner. Affects MuJoCo, MJWarp, Motrix, Genesis, and Newton owner YAMLs for g1_motion_tracking on Linux. Ref #2613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2613. Two coupled changes, governed by the new ADR-0023:
1. flashsac
g1_motion_trackingaligns with the SAC owner contractbase.yamlnow carries the same scene/observation/command/reward/termination contract as SAC: canonical training DR (base_com/encoder_bias/foot_frictionreset terms +push_robotinterval push), footgeom_names, and the biased actor joint observation (motion_joint_pos_rel_biased). Training budget already matched (2048 envs x 25000 iters); FlashSAC algo knobs stay atconf/flashsac/config.yamldefaults.body_mass/pd_gainssubset. The Newton owner keeps its historical DR-free behavior with all four events explicitlynull(no SAC Newton owner exists to align with, and Newton's public tensor mask reset does not support randomization).2. Task sim owners inherit same-directory
base.yamlonly (ADR-0023)sac/flashsac/appo/pponow declaredefaults: [/task/<task>/base, _self_]; cross-backend inheritance removed (10 violating leaves:g1_motion_trackingmotrix/mjwarp/genesis/newton in four algo trees,go2_joystick_flat/superdex).appo/ppog1_motion_trackinggain the missingbase.yaml; shared DR and training budgets move intobase.yaml; leaves carry their fulltask_name/sim_backendidentity per ADR-0003.tests/config/test_config_system.pygains a structural guard test over every leaf.Impact
g1_motion_trackingalignment itself. Composed-config snapshots (Hydra compose, 17 affected combos) diff key-identical before/after except flashsacg1_motion_tracking; remaining sac diffs are pure YAML key ordering.g1_motion_tracking; Linux.Validation (final head
9d1bbaf7)make test-all— 3041 passed, 37 skipped, 1 xfailed (includesmake check: ruff + mypy/pyright clean)pytest tests/config/ -q(19) and-m slow(44);pytest tests/scripts/test_train_scripts.py -m slow -k "g1_motion_tracking or superdex or go2_joystick"(7 passed, 2 pre-existing env failures now resolved afteruv sync --all-extras);pytest tests/scripts/test_check_docs.py(20)-n) clean; flashsac task no longer described as DR-free in tensor-runtime / sync-free-autoreset pagesGoverning decision: {ADR-0023} (added in this PR); extends {ADR-0003}.