Repository navigation
fix(uni-cumps): add stop --gpus selector and actionable stop errors - #2611
Merged
Merged
Conversation
The name-only stop surface trapped users in the recommended one-daemon-per-GPU setup: bare stop was ambiguous, stop --gpus did not exist, and failures never named a next step. - stop accepts --gpus <index-or-uuid> (exclusive with --name/--all), resolving the unique live recorded daemon covering that GPU; zero or multiple matches fail closed and name the candidates - stop/env selection errors point at uni-cumps status; start --name help corrected to gpu-<full-uuid>; shell completion updated - README and training guide (en/zh) document the full status -> start -> train -> stop lifecycle, stop --all, the default-name rule, and the orphan-daemon manual recovery path - ADR-0014 (Proposed) amended: --gpus stop selector supersedes the name-only stop surface; discoverability is part of the CLI contract Closes #2610
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uni-cumps stopgains--gpus <index-or-uuid>(mutually exclusive with--name/--all), resolving the unique live recorded daemon covering thatGPU; zero or multiple matches fail closed and name the candidates.
(
uv run uni-cumps status);start --namehelp corrected togpu-<full-uuid>; shell completion offers the new flag.status → start → train → stop lifecycle,
stop --all, the default-namerule, and the orphan-daemon manual recovery path.
--gpusstop selectorsupersedes the name-only stop surface, and discoverability (errors point at
status) is now part of the CLI contract.invocations — the name-only stop surface contradicts the recommended
one-daemon-per-GPU flow (bare
stopis always ambiguous there), and thedocs showed only the happy path.
Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
Note: the first local
make test-allattempt failed at collection becausethis venv lacked the optional extras CI installs; after syncing the same
extras the full gate passes.
Remote CI route:
main: current-head CI link and status to be recorded after the run starts.Impact
Artifacts
make test-all)Checklist