Skip to content

fix(uni-cumps): add stop --gpus selector and actionable stop errors - #2611

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-2610-uni-cumps-stop-usability
Nov 16, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-2610-uni-cumps-stop-usability

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • uni-cumps stop gains --gpus <index-or-uuid> (mutually exclusive with
    --name/--all), resolving the unique live recorded daemon covering that
    GPU; zero or multiple matches fail closed and name the candidates.
  • Stop/env selection failures now name the next discovery step
    (uv run uni-cumps status); start --name help corrected to
    gpu-<full-uuid>; shell completion offers the new flag.
  • README and the training guide (en/zh) now document the full
    status → start → train → stop lifecycle, stop --all, the default-name
    rule, and the orphan-daemon manual recovery path.
  • ADR-0014 (still Proposed) amended in place: the --gpus stop selector
    supersedes the name-only stop surface, and discoverability (errors point at
    status) is now part of the CLI contract.
  • Why: the issue's shell-history evidence shows ~20 failed/guess-driven
    invocations — the name-only stop surface contradicts the recommended
    one-daemon-per-GPU flow (bare stop is always ambiguous there), and the
    docs showed only the happy path.
  • User-facing impact: management CLI only; no training behavior change.

Linked Work

Validation

  • make test-all passed on the final local head before this PR was created or updated
  • Additional task-specific validation listed below

Commands actually run:

uv sync --extra mujoco --extra mjwarp --extra unirl   # CI-equivalent extras
uv run pytest tests/training/test_cuda_mps_cli.py -q  # 48 passed
uv run pytest tests/test_completion.py -q             # 17 passed
make check                                            # ruff + mypy + pyright: 0 errors
uv run pytest tests/scripts/test_check_docs.py -q     # 20 passed
cd docs/sphinx && UNILAB_DOCS_SKIP_AUTODOC=1 \
  uv run --no-project --with-requirements requirements.txt \
  sphinx-build -b html -n source build/html           # success, pre-existing warnings only
make test-all                                         # check + test-cov + benchmark smoke: all pass

Note: the first local make test-all attempt failed at collection because
this venv lacked the optional extras CI installs; after syncing the same
extras the full gate passes.

Remote CI route:

  • Base main: current-head CI link and status to be recorded after the run starts.

Impact

  • Backend impact: none
  • Platform impact: Linux (NVIDIA CUDA MPS management CLI only)
  • Training effect expected: no

Artifacts

  • W&B: n/a
  • benchmark result: benchmark smoke 35/35 + 36/36 (part of make test-all)
  • video / screenshot: n/a
  • ONNX / checkpoint: n/a

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly (record remote CI status before merge)

The name-only stop surface trapped users in the recommended
one-daemon-per-GPU setup: bare stop was ambiguous, stop --gpus did not
exist, and failures never named a next step.

- stop accepts --gpus <index-or-uuid> (exclusive with --name/--all),
  resolving the unique live recorded daemon covering that GPU; zero or
  multiple matches fail closed and name the candidates
- stop/env selection errors point at uni-cumps status; start --name help
  corrected to gpu-<full-uuid>; shell completion updated
- README and training guide (en/zh) document the full
  status -> start -> train -> stop lifecycle, stop --all, the default-name
  rule, and the orphan-daemon manual recovery path
- ADR-0014 (Proposed) amended: --gpus stop selector supersedes the
  name-only stop surface; discoverability is part of the CLI contract

Closes #2610
@TATP-233
TATP-233 merged commit c23bdcf into main Nov 16, 2026
12 checks passed
@TATP-233
TATP-233 deleted the fix/issue-2610-uni-cumps-stop-usability branch November 16, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uni-cumps: stop/discovery UX traps users — add GPU selector, actionable errors, lifecycle docs

1 participant