fix: use platform-native path separators in user-facing output (Windows)#449
Closed
RTCartist wants to merge 3 commits into
Closed
fix: use platform-native path separators in user-facing output (Windows)#449RTCartist wants to merge 3 commits into
RTCartist wants to merge 3 commits into
Conversation
…ndows `config.toml`'s path is resolved via `pathe` (forward slashes everywhere) while `tui.toml`'s path is resolved via `node:path` (native separators). On Windows this surfaced a mixed-separator output in `kimi doctor`: SKIP config.toml C:/Users/me/.kimi-code/config.toml SKIP tui.toml C:\Users\me\.kimi-code\tui.toml Normalize each path with `node:path` `normalize()` in `formatResults` so both lines render with the platform-native separator, matching what the user sees elsewhere in the TUI (working-directory badge, etc.).
🦋 Changeset detectedLatest commit: f6c7286 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The SDK resolves the global log path via `pathe` (forward slashes everywhere), so startup-error fallbacks were showing "See log: C:/Users/me/.kimi-code/logs/kimi-code.log" on Windows. Normalize via `node:path` `normalize()` before display so the path matches what users see in File Explorer / their shell.
RTCartist
changed the title
Collaborator
|
Sorry, we currently do not accept PRs submitted in batches using AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while installing kimi-code 0.10.1 on Windows. Two user-facing path-display bugs caused by
pathe(forward-slash everywhere) leaking into output the user actually sees:1.
kimi doctormixes separatorsconfig.toml→resolveConfigPathinpackages/agent-core/src/config/path.tsusesjoinfrompathetui.toml→getTuiConfigPathinapps/kimi-code/src/tui/config.tsusesjoinfromnode:pathNormalize each path with
node:path.normalize()informatResults.2.
See log:startup-error fallback uses forward slashesresolveGlobalLogPathinpackages/agent-core/src/logging/logger.tsusespathe. Wrap with a tinyformatLogPathForUserhelper inmain.tsthat runs the output throughnode:path.normalize()before showing it.Display-only changes — no path comparison, file resolution, JSON output, or test fixture relies on the raw separator. The deeper fix (switching
resolveConfigPath/resolveGlobalLogPathtonode:path) would touch too many internal callers and risks subtle behavior changes; normalizing at the display boundary is the safe surgical fix.Test plan
normalizes path separators in formatted outputindoctor.test.tscovering both POSIX and Windows separatorsnpm install -g @moonshot-ai/kimi-code)