Repository navigation
Conversation
Next Up, the end of an episode and the episode browser started the next episode on this TV alone. The group's commands for the previous entry then landed on it, so Next Up kept coming back and played on through the series. Moving on now goes through the group, as on Moonfin-Core, and commands for another queue entry are dropped. Queue edits and repeat or shuffle changes also no longer start the group's item on a TV that has nothing playing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
✅ Build SuccessfulAll platform builds and the test suite passed. You can download the artifacts below.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inside a SyncPlay group, the next episode started on this TV alone. The group's commands for the previous entry then landed on it, so Next Up kept coming back and played on through the series. Moving on now goes through the group, as on Moonfin-Core.
Split out of #538, which keeps the group queue and the in-player SyncPlay button and builds on this one.
Related Issues
Type of Change
Changes Made
Platform
Testing
Draft: testing on a Samsung TU43DU7105KXXC (Tizen 9) is in progress. webOS shares the code but won't be tested, as I have no LG set.
npm test --workspace @moonfin/apppasses (254 suites with #538 on top), as donpm run lintandnpm run lint:css.Test Steps
Screenshots (if applicable)
No visual change.
Checklist
Written with help from an AI assistant (Claude Code). I'm testing it on my own TV before marking it ready.
🤖 Generated with Claude Code