Skip to content

Move on to the next episode through the SyncPlay group - #540

Draft
Kisnov wants to merge 1 commit into
Moonfin-Client:mainfrom
Kisnov:fix/syncplay-next-through-group
Draft

Kisnov wants to merge 1 commit into
Moonfin-Client:mainfrom
Kisnov:fix/syncplay-next-through-group

Conversation

@Kisnov

@Kisnov Kisnov commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Inside a SyncPlay group, the next episode started on this TV alone. The group's commands for the previous entry then landed on it, so Next Up kept coming back and played on through the series. Moving on now goes through the group, as on Moonfin-Core.

Split out of #538, which keeps the group queue and the in-player SyncPlay button and builds on this one.

Related Issues

  • None open.

Type of Change

  • Bug fix

Changes Made

  • Next Up, the end of an episode and the episode browser ask the group to move on (next, previous or a queue entry) instead of playing the episode here. The group's queue update then brings every player along.
  • A command for another queue entry is dropped, as Core does.
  • Queue edits and repeat or shuffle changes no longer start the group's item on a TV that has nothing playing.

Platform

  • Tizen (Samsung)
  • webOS (LG)
  • Vega (Fire TV)
  • Xbox
  • All / Shared code

Testing

  • Tested on emulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Draft: testing on a Samsung TU43DU7105KXXC (Tizen 9) is in progress. webOS shares the code but won't be tested, as I have no LG set. npm test --workspace @moonfin/app passes (254 suites with #538 on top), as do npm run lint and npm run lint:css.

Test Steps

  1. Join a SyncPlay group from two devices and play an episode of a series.
  2. Let Next Up count down at the end: both devices move on together and Next Up doesn't come back.
  3. Reorder or remove a queue entry from a device sitting outside the player: it stays where it is.

Screenshots (if applicable)

No visual change.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Written with help from an AI assistant (Claude Code). I'm testing it on my own TV before marking it ready.

🤖 Generated with Claude Code

Next Up, the end of an episode and the episode browser started the next
episode on this TV alone. The group's commands for the previous entry then
landed on it, so Next Up kept coming back and played on through the series.
Moving on now goes through the group, as on Moonfin-Core, and commands for
another queue entry are dropped.

Queue edits and repeat or shuffle changes also no longer start the group's
item on a TV that has nothing playing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the Bug Something isn't working label Oct 17, 2026
@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the Tizen label Oct 17, 2026
@github-actions

Copy link
Copy Markdown

✅ Build Successful

All platform builds and the test suite passed. You can download the artifacts below.

Platform Status Artifact
webOS ✅ Passed Moonfin_webOS_*.ipk
Tizen Regular ✅ Passed Moonfin_Tizen_Regular_*.wgt
Tizen Oblong ✅ Passed Moonfin_Tizen_Oblong_*.wgt
Tizen Legacy ✅ Passed Moonfin_Tizen_Legacy_*.wgt
Vega ✅ Passed web bundle and shell checks
Property Value
Commit 56e8475
Workflow run Build #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Tizen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant