Support qualified names in function operations - #190
Open
alexwp10 wants to merge 3 commits into
Open
Conversation
Contributor
|
Sieht gut aus, bitte noch Version um 1 erhöhen in der gradle.properties und danach den gleichen PR auch auf den Main-Branch stellen! |
mathias-pfeiffer
marked this pull request as draft
August 3, 2026 21:01
alexwp10
marked this pull request as ready for review
August 10, 2026 08:16
|
|
||
| SysMLFunctionOperationExpression implements Expression <291> = | ||
| Expression "->" Name | ||
| Expression "->" SysMLQualifiedName |
Contributor
There was a problem hiding this comment.
Suggested change
| Expression "->" SysMLQualifiedName | |
| Expression "->" MCQualifiedName |
|
|
||
| # Version of published artifacts | ||
| version = 7.8.72 | ||
| version = 7.8.73 |
Contributor
There was a problem hiding this comment.
Bitte mit aktuellem Stand vergleichen (git rebase), wir sind bereits bei 7.8.75+
mathias-pfeiffer
marked this pull request as draft
August 10, 2026 09:24
alexwp10
force-pushed
the
fix/function-operation-qualified-name
branch
from
August 10, 2026 10:32
991158f to
04ef8a8
Compare
alexwp10
marked this pull request as ready for review
August 10, 2026 19:01
| assertThat(functionOperation.getExpression()) | ||
| .isInstanceOf(ASTFieldAccessExpression.class); | ||
| assertThat(functionOperation.getName()).isEqualTo("c"); | ||
| assertThat(functionOperation.getSysMLQualifiedName().getPartsList()).containsExactly("c"); |
Contributor
There was a problem hiding this comment.
Kommentar noch nicht beachtet: https://github.com/MontiCore/sysmlv2/pull/190/changes#r3748184776
mathias-pfeiffer
marked this pull request as draft
August 12, 2026 12:15
alexwp10
force-pushed
the
fix/function-operation-qualified-name
branch
from
August 12, 2026 14:23
1b03c29 to
ff2b6b7
Compare
alexwp10
marked this pull request as ready for review
August 12, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for qualified names in function operation expressions.
Function names following the -> operator can now be qualified using both . and ::. The parser tests cover all combinations of qualified names on both sides of the function operation:
a.b->c.d
a::b->c::d
a::b->c.d
a.b->c::d
The existing parser test was updated to use the generated SysMLQualifiedName AST node.