Repository navigation
Add convenience function for downloading a project attachment - #1067
Merged
Merged
Conversation
Mirrors BaseDataset.download_attachment: looks up the attachment (refetching if the cached list is stale), raises ValueError listing valid ids, and returns the destination path. Defaults to not overwriting existing files. Assisted-by: claude-code:claude-sonnet-5-5
Matches Project.download_attachment, ExternalFile.download and PortalClient.download_external_file, and fails safe instead of silently clobbering an existing file. Internal cache use already passes overwrite=True. Assisted-by: claude-code:claude-sonnet-5-5
Assisted-by: claude-code:claude-sonnet-5-5
…to download_proj_attach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In QCPortal, adds a function to the Project model to download an attachment to mirror the Dataset model functionality. It was always possible before to go through the
attachmentsproperty, but this can make it a little easier.Also modified the dataset download_attachment function to not overwrite by default (to make it a little safer to use)
Status