Repository navigation
Fix units registry for pint 0.26.2 CODATA unit braces - #418
Merged
Merged
Conversation
pint 0.26.2 raises on unknown operators instead of ignoring them, so the
LaTeX-style exponents in CODATA unit strings (e.g., "J^{-2}") broke
build_units_registry and thus test collection. Convert braces to
parentheses before defining the atomic units. Tested with pint 0.24.4,
0.25.3, and 0.26.2.
Fixes MolSSI#417
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pint 0.26.2 raises on unknown operators instead of ignoring them, so the LaTeX-style exponents in CODATA unit strings (e.g., "J^{-2}") broke build_units_registry and thus test collection. Convert braces to parentheses before defining the atomic units. Tested with pint 0.24.4, 0.25.3, and 0.26.2.
Fixes #417
Description
Changelog description
Status