[ragnorc]

Three last items from the wider review that #50 and #51 left open. Based on main (6216514) and independent of #51.

A CLI run ends when the CLI does (graph_store)

A run read the CLI's output to the end before it waited for the CLI to exit. A program the CLI started that held its output open and outlived it (a credential helper's background process, for example) kept the run going until Studio's timeout. That held the one CLI turn for 30 s or more. The run now waits for the exit beside the reads. Once the CLI has ended, its pipes are read for 250 ms more, long enough to deliver what it wrote.

A list cell takes a list pasted in JSON (gq_language)

A list parameter read JSON (["a","b"], the form a list value is copied in) or comma-separated items. A list cell, form field or bulk edit read only the comma form, so a copied list pasted into a cell was refused. One reader, input::list_texts, now reads both for cells and parameters. It also covers [], so the special case for an empty list goes.

The gateway's held-clause rule beside the compiler's (agent_panel, test only)

The gateway decides from tokens alone whether a mutation is written as commit or as unattached branch, so that text the compiler can't parse isn't let through unread. Its test now pins two things: wherever the compiler's parse finds the clause, the gateway refuses; where neither finds it, both let the write through.

Testing

• cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace (1,166 passed) and the repo checks pass locally, on top of the current main.
• cli_tokens::tests::input_a_command_does_not_read_ends_at_its_timeout (extended with a script that leaves a background process holding its output) and input::tests::a_list_reads_back_as_it_was_written (extended with pasted JSON) both fail without their fixes (checked).

Checked and left

• Unused code: no pub function in the workspace is named only where it's defined, and no crate has an unused dependency. The one hit, studio_theme's util, is there for its debug-embed feature.
• Coalescing settings writes: the writes arrive debounced at their sources, and the write thread's strict order is what read-edit-write jobs and the quit-time flush rely on.

---

Note

Medium Risk
Changes how Studio waits on Omnigraph CLI subprocess I/O (affects token export and CLI turn duration), plus shared list parsing for edits and parameters.

Overview
CLI subprocess handling no longer blocks until stdout/stderr pipes close. run_once races pipe reads against process exit; after the CLI exits, pipes are drained for 250 ms so output is captured without waiting on detached helpers (e.g. credential helpers). A regression test covers a script that backgrounds a long sleep while printing a token.

List property input is unified through new list_texts: bracket-leading text is parsed as JSON (as when copying a list value), otherwise comma-separated items as before. Form cells and query parameters both use this path; the separate empty-list shortcut in parse_input is removed. Tests cover pasted ["a", "b"] and reject null elements.

Gateway mutation tests only: held vs allowed as commit cases are named arrays, with assertions that held_off_the_branch (token scan) aligns with the compiler’s declared_write parse wherever both apply.

^{Reviewed by Cursor Bugbot for commit 13fb56b. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 13fb56b. Configure here.}

[cursor]

Pipes stay open past read bound

Medium Severity

A pipe that hits its read bound no longer closes. The Take wrappers now outlive the reads and stay open through child.status(), so a command that writes past the bound can fill the OS pipe and block. That holds the CLI turn until the outer timeout, instead of ending once the bound is read.

 

^{Reviewed by Cursor Bugbot for commit 13fb56b. Configure here.}