Repository navigation
fix(studio): the design gallery is in debug builds only - #48
Open
aaltshuler wants to merge 1 commit into
Open
aaltshuler wants to merge 1 commit into
aaltshuler wants to merge 1 commit into
Conversation
It is for working on Studio, but a release build offers it in the palette as a tab beside the person's data. `cfg(debug_assertions)`, not a feature: CI passes no features, so a feature's code would stop being compiled. The action stays defined, and a release build's palette lists only available actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the plan to cut Studio's bloat. The design gallery is a tool for working on Studio, yet a release build offers it in the command palette.
It now compiles only into debug builds. I used
cfg(debug_assertions)rather than a Cargo feature because CI passes no features, so feature-gated code would stop being compiled and checked. The action stays defined and stays inPALETTE_ONLY; a release build's palette lists only available actions, so it doesn't appear. A saved gallery tab is skipped on restore in a release build.Test
cargo clippy -p studio --all-targets -- -D warnings--config 'profile.dev.package.studio.debug-assertions=false', which compiles Studio the way a release does without rebuilding its dependencies. I didn't run a full release build, because this machine has no CMakecargo test -p studio,cargo fmt --all --check,check-design-tokens.py,check-brand.py🤖 Generated with Claude Code