Repository navigation
fix(settings): say nothing of a setting Studio no longer has - #46
Merged
Merged
Conversation
A key left in `settings.json` after its setting goes raises an error toast at every start. List the settings about to go (the agent's, model calls', panel placement, three appearance settings) so a file that still names them reads clean. Their text stays, as any other key's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of the plan to cut Studio's bloat, following the UX audit.
A key left in
settings.jsonafter its setting is removed raises an error toast at every start (document.rs, "is not a setting, so it does nothing"). This adds a list of the settings the plan removes, so a file that still names them reads clean. Their text stays in the file.Nothing changes yet: every listed setting still exists, so none of them reaches this path until its removal lands.
agent.omnigraph_cliis still reported, because only the agent's own settings are listed.Listed:
agent.command,agent.env,agent.ask_before_writes,models,panels,studio.window_style,studio.corner_radius,studio.bottom_dock_layout.Test
cargo test -p studio_settings, with two new tests indocumentcargo clippy -p studio_settings --all-targets -- -D warnings,cargo fmt --all --check,check-brand.py🤖 Generated with Claude Code