Skip to content

Add localization interfaces and improve table injection - #124

Open
altairwei wants to merge 70 commits into
ModShardTeam:mainfrom
altairwei:PickRemyCasesWork
Open

altairwei wants to merge 70 commits into
ModShardTeam:mainfrom
altairwei:PickRemyCasesWork

Conversation

@altairwei

Copy link
Copy Markdown
Collaborator

This PR bring back @remyCases WIP branch to main branch.

…, removes npclines and consumables table injection from LocalizationUtils
…set class, adds a generic InjectTable in Localization, removes the Loc member in interface item since each table behaves differently
@altairwei
altairwei requested a review from remyCases August 16, 2025 01:13
Resolve conflicts introduced by the ModShardTeam#127/ModShardTeam#128 refactors:
- DataLoader: adopt upstream's Loader-based layout, keep the branch's
  exportPath and LastCountContext additions
- FilePacker: keep the branch's dll-folder argument on upstream's
  void UtilsPacker.Pack (no try/catch)
- csproj: recursive ModUtils glob alongside upstream's Core glob, and
  keep the branch's CopyDevFiles publish copies
- port upstream's logging cleanups into the moved ModUtils/RandomUtils.cs
- keep the removal of ModShardLauncherTest/LocalizationUtilsTest.cs
  (superseded by TableTest/LocalizationUtilsTest.cs)

Also fix a pre-existing compile error from a7cb402: InjectTableMobsStats
used {noTP} in the row template without declaring the parameter; add
bool noTP = false and render it like the neighbouring flags.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants