Repository navigation
fix(server): an app on tables of its own starts its sample afresh - #98
Merged
Merged
Conversation
MoSofi
force-pushed
the
fix/app-reinstall-sample-ledger
branch
from
October 11, 2026 13:11
df37825 to
d33ce68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An app installed again on tables of its own starts its sample afresh.
The case. An app is removed and installed again, and the new install reuses none of the earlier tables: they were dropped with it, or they were an older version's under plain names. The earlier install's list of sample rows was still counted with the new one, which doubled the count shown.
The change.
main).<app>_sample_data: which rows are sample), never one of its data tables. Rows an earlier version left behind stay as ordinary rows.Tests. Folded into
app-sample-reinstall.test.ts: the released Point of Sale app on every engine the run can reach: still the sample over kept tables; afresh on tables of its own; afresh after its tables were dropped.History. Written on 2026-10-08 and never merged. Rebuilt as one commit on today's
main: the commitmainalready had was left out, one conflict ininstall-service.tsresolved by keepingmain's check that the list's table exists, the changeset cut to what is new.