Conversation
- TelemetryService uses sago::getConfigHome() (per-user) - ServerFifoPath uses XDG_RUNTIME_DIR or /var/run with 0700/owner checks - DaemonCreator uses 0600 pidfile - Added audit docs and secure-temp tests (symlink/race behavior)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
==========================================
- Coverage 79.26% 79.18% -0.08%
==========================================
Files 118 118
Lines 12633 12633
Branches 8143 8143
==========================================
- Hits 10014 10004 -10
- Misses 1552 1569 +17
+ Partials 1067 1060 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MisterTea
changed the title
Owner
Author
|
Superseded by the security hardening and regression coverage merged in #784. This branch contains audit notes and non-executable placeholders only, so it should not remain open as a competing security fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #778 for the original report.
Changes
Adds audit notes covering telemetry configuration, FIFO paths, PID-file permissions, and possible symlink races.
Resolution status
The files are documentation/placeholders rather than executable security tests, and no hardening change is included. This PR does not establish that CVE-2023-23558 is fixed.
Verification
Reviewed against current master. Run the repository-required formatting and unit-test commands after any follow-up code changes.