Skip to content

fix: honor ProxyJump none in SSH config (#653) - #830

Merged
MisterTea merged 3 commits into
masterfrom
issue-653
Sep 21, 2026
Merged

MisterTea merged 3 commits into
masterfrom
issue-653

Conversation

@MisterTea

@MisterTea MisterTea commented Sep 20, 2026 •

Copy link
Copy Markdown
Owner

Preserves the ProxyJump none sentinel, applies first-value-wins config semantics, and lets command-line --jumphost none disable config fallback. Targeted tests pass with 5 assertions.

Closes #653.

@codecov

codecov Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.23%. Comparing base (651fe3e) to head (b638dbf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
+ Coverage   79.20%   79.23%   +0.02%     
==========================================
  Files         119      120       +1     
  Lines       12685    12702      +17     
  Branches     8180     8189       +9     
==========================================
+ Hits        10047    10064      +17     
  Misses       1568     1568              
  Partials     1070     1070              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MisterTea MisterTea changed the title Issue: issue-653 fix: support ProxyJump none in SSH configuration (#653) Sep 20, 2026
@MisterTea MisterTea changed the title fix: support ProxyJump none in SSH configuration (#653) fix: honor ProxyJump none in SSH config (#653) Sep 20, 2026
MisterTea and others added 2 commits September 21, 2026 08:24
…n precedence tests

- Handle 'none' in ssh_options_set (SSH_OPTIONS_PROXYJUMP) like ProxyCommand
- Allow ProxyJump override in parse line (remove first-only guard) so 'none'
  can override a prior jump host value
- Add ProxyJumpTest.cpp covering unset, set-to-none, and precedence
@MisterTea
MisterTea merged commit a836741 into master Sep 21, 2026
37 of 49 checks passed
@MisterTea
MisterTea deleted the issue-653 branch September 21, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support overriding the jump host to an empty one (none)

1 participant