Skip to content

chore(tui): restore ESLint rules and verification gate - #341

Merged
hetaoBackend merged 1 commit into
mainfrom
chore/tui-eslint
Sep 23, 2026
Merged

hetaoBackend merged 1 commit into
mainfrom
chore/tui-eslint

Conversation

@hetaoBackend

@hetaoBackend hetaoBackend commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Change

The public TUI had no ESLint configuration, dependencies, lint command or verification gate, so source-policy violations could pass CI. Add pnpm lint / pnpm lint:tui for TUI source and tests and run the gate through the shared verifier, including full, platform, archive and Windows profiles.

Adapt the source repository's Airbnb-base, TypeScript, import and Prettier policy, retaining the audited Pi engine's narrow exceptions and warning severities. Pin the existing source toolchain (ESLint 8.57.1 / TypeScript ESLint 7.18.0) for rule parity; a toolchain upgrade is separate work. React/browser rules are outside this Node TUI scope. The scripts use --quiet to suppress existing warning output without changing rule severity; invoke ESLint directly without it to inspect warnings. Upstream Pi test copies are excluded, while first-party tests are checked.

Fix 13 existing errors with local renames, equivalent expressions, merged imports and one documented test-only packaging import exception. Add regressions for rule enforcement, test coverage, engine/facade exceptions and verifier failure propagation. Update contributor guidance, the development skill, dependency licenses and source inventory.

Validation

  • PASS: pnpm verify on clean commit 151fc6266189c5796c5f97b5271bf54fd59503e9, full profile, macOS arm64 / Node 26.4.0: all 15 applicable gates in 180 seconds. Capability suite: 172 files, 4,585 tests passed, 14 skipped under existing conditions.
  • PASS: frozen offline installation, standalone pnpm lint, lint contract regressions and git diff --check.
  • PASS: Gitleaks on complete HEAD ancestry (101 commits) and exported source, using the repository configuration.
  • Performance: basic; no performance optimization or runtime pipeline change.
  • NOT RUN locally: native Linux/Windows, live services and npm release archive installation. Remote CI remains separate evidence.

Publication and contribution checks

  • Existing applicable licenses and source provenance preserved; only the reviewed TUI lint policy is adapted.
  • No credentials, account data, real user content, internal history or private review material included.
  • New config reviewed before regenerating the inventory; regression coverage belongs to the existing release-tools suite.
  • English contributor guidance and the verification skill updated; offline results are not live-service acceptance.

Maintainer handoff

Publication scope: one ESLint configuration plus development-only dependencies. Shared-source port: not needed for distribution-specific verification wiring; lint cleanup can be ported through the normal public-to-source process.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@hetaoBackend hetaoBackend added enhancement New feature or request tui Interactive terminal UI (TUI) cli Standalone mcode: TUI, headless, ACP and source builds/tooling labels Sep 23, 2026
@hetaoBackend
hetaoBackend merged commit a914a30 into main Sep 23, 2026
27 checks passed
@hetaoBackend
hetaoBackend deleted the chore/tui-eslint branch September 23, 2026 13:22
tournierjc pushed a commit to tournierjc/kinetick-code that referenced this pull request Sep 23, 2026
…ollow-up)

- auth/application.ts: drop the no-useless-catch try/catch wrapper in login()
- transcript/usage-visualization.ts, update/application.ts: prefer-template
- update-release.test.ts: prefer-template in fixture URLs
- package-identity.test.ts: import the scripts/lib/package-identity.mjs via
  import.meta.resolve so the cross-package reference satisfies
  import/no-relative-packages while keeping the vitest resolution path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Standalone mcode: TUI, headless, ACP and source builds/tooling enhancement New feature or request tui Interactive terminal UI (TUI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant