chore(tui): restore ESLint rules and verification gate - #341
Merged
Merged
Conversation
tournierjc
pushed a commit
to tournierjc/kinetick-code
that referenced
this pull request
Sep 23, 2026
…ollow-up) - auth/application.ts: drop the no-useless-catch try/catch wrapper in login() - transcript/usage-visualization.ts, update/application.ts: prefer-template - update-release.test.ts: prefer-template in fixture URLs - package-identity.test.ts: import the scripts/lib/package-identity.mjs via import.meta.resolve so the cross-package reference satisfies import/no-relative-packages while keeping the vitest resolution path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The public TUI had no ESLint configuration, dependencies, lint command or verification gate, so source-policy violations could pass CI. Add
pnpm lint/pnpm lint:tuifor TUI source and tests and run the gate through the shared verifier, including full, platform, archive and Windows profiles.Adapt the source repository's Airbnb-base, TypeScript, import and Prettier policy, retaining the audited Pi engine's narrow exceptions and warning severities. Pin the existing source toolchain (ESLint 8.57.1 / TypeScript ESLint 7.18.0) for rule parity; a toolchain upgrade is separate work. React/browser rules are outside this Node TUI scope. The scripts use
--quietto suppress existing warning output without changing rule severity; invoke ESLint directly without it to inspect warnings. Upstream Pi test copies are excluded, while first-party tests are checked.Fix 13 existing errors with local renames, equivalent expressions, merged imports and one documented test-only packaging import exception. Add regressions for rule enforcement, test coverage, engine/facade exceptions and verifier failure propagation. Update contributor guidance, the development skill, dependency licenses and source inventory.
Validation
pnpm verifyon clean commit151fc6266189c5796c5f97b5271bf54fd59503e9, full profile, macOS arm64 / Node 26.4.0: all 15 applicable gates in 180 seconds. Capability suite: 172 files, 4,585 tests passed, 14 skipped under existing conditions.pnpm lint, lint contract regressions andgit diff --check.Publication and contribution checks
Maintainer handoff
Publication scope: one ESLint configuration plus development-only dependencies. Shared-source port: not needed for distribution-specific verification wiring; lint cleanup can be ported through the normal public-to-source process.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.