fix(skills): discover linked workspace skill directories - #337
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Workspace Skills were silently omitted when
.agents/skills,.claude/skills, or.minimax/skillswas a directory symlink, or when an individual Skill directory linked outside its source root. Opt the configured compatibility sources into directory-link resolution and watch linked directories even beforeSKILL.mdexists. Source enable settings and duplicate-name priority remain in effect; generic bounded roots and the rejection ofSKILL.mdfile symlinks are unchanged.Add 13 regression cases covering linked roots and children, relative and absolute targets, duplicate aliases, source disabling, link retargeting, live creation/edits, invalid links, and bounded-root behavior. Document the supported layouts.
Validation
VITEST_MAX_WORKERS=2 pnpm verifyon clean commiteaf23caf046fd82a66d376bf4cdfeaafba83f4a7, macOS arm64 / Node 26.4.0, full profile: 14 gates passed (185.8 seconds), including 170 capability files / 4,549 passing tests..agents/skillsand.claude/skillsroot aliases with a child link outside the workspace; confirmed the linked Skill appears in the model request and the CLI exits successfully. Uses a local synthetic provider with external network access denied.perf:fullclassification applies.Publication and contribution checks
test/vitest-suites.json, and recorded by regeneratingrelease/public-source.json.Maintainer handoff
Publication scope or license changes: none.
Shared-source port: pending.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.