fix(tui): reset rewound todos and keep commands local during edits - #336
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Reproduce and fix two TUI failures around historical message editing:
/historyand submitting a replacement prompt, history reconciliation kept the old todo projection when the rewound history contained no todo event. Rebuild todos alongside the replaced history so discarded tasks disappear and earlier retained tasks are restored./rewindcommand went througheditSessionMessageas prompt text. Resolve local commands before intercepting an edit submission; skills, explicit message submissions, and ordinary slash-prefixed prose retain their message behavior.Ordinary conversation-only rewind and
/rewindoutside editing were already passing. The new app-level regressions failed on the original implementation specifically for history editing, then passed with these changes.Validation
VITEST_MAX_WORKERS=4 pnpm verifyon clean commit803ff35605fa2fd7f1dd5c2414895a73f7025053, full macOS profile: all 14 applicable gates. Capability gate: 169 files, 4542 passed / 14 skipped. Windows and npm release-archive gates are inapplicable to this local profile.perf:fullbecause this changes history projection refresh. Remote performance and CI results are pending; latest-head full performance evidence is required before merge.Publication and contribution checks
Maintainer handoff
Publication scope or license changes: none.
Shared-source port: pending.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.