Skip to content

fix(tui): keep interrupted footer hidden during edit resubmission - #332

Merged
hetaoBackend merged 1 commit into
mainfrom
fix/clear-interrupted-duration-on-edit
Sep 23, 2026
Merged

hetaoBackend merged 1 commit into
mainfrom
fix/clear-interrupted-duration-on-edit

Conversation

@hetaoBackend

@hetaoBackend hetaoBackend commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Change

Fix the remaining interrupted-duration flash when a user interrupts a response, presses Escape twice to restore the query, and submits the edited query.

The edit path bypasses normal message submission. Its history refresh can remove the old message anchor while retaining the ephemeral duration footer, including when message.rewind arrives before the edit RPC returns.

  • Keep the captured old footer hidden while the edit is pending, even if its message anchor disappears.
  • Remove only that captured footer after a successful edit or an error confirming history was already rewound.
  • Preserve the old footer when an unchanged edit is cancelled, and preserve a replacement turn's completion footer.
  • Add nine app-level terminal-screen regressions covering submit, cancel, failure/retry states, early rewind events, and fast completion.

Validation

  • Focused app/history suites: 317 tests passed.
  • The early-rewind and committed-rewind-error regressions failed before their respective fixes and passed afterward.
  • pnpm typecheck and git diff --check: passed.
  • Independent subagent review: findings fixed; final review found no remaining actionable issues.
  • Full pnpm verify on clean committed 3b861def3db7bb80e46bcb019fda0425e2a8d111: all 14 applicable macOS gates passed. Windows and release-package gates were not applicable.
  • Performance: basic; this changes presentation state and edit footer cleanup, not runtime history construction or persistence.
  • NOT RUN: native Apple Terminal visual acceptance, live model traffic, Linux/Windows locally. The screen tests use synthetic runtime events and a terminal emulator.

Publication and contribution checks

  • Existing licenses and notices are preserved; no imported material.
  • No credentials, account data, real user content, internal source history or private review material is included.
  • Only existing source/test files changed; no inventory or test registration changes are required.
  • No documentation or capability contract changes. Offline results are not described as live-service acceptance.

Maintainer handoff

Publication scope or license changes: none.

Shared-source port: pending.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@hetaoBackend hetaoBackend added bug Something isn't working tui Interactive terminal UI (TUI) cli Standalone mcode: TUI, headless, ACP and source builds/tooling labels Sep 23, 2026
@hetaoBackend
hetaoBackend merged commit b2f146a into main Sep 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli Standalone mcode: TUI, headless, ACP and source builds/tooling tui Interactive terminal UI (TUI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant