Skip to content

Allow reconnect after settled initialization uncertainty - #658

Merged
SaladDay merged 1 commit into
mainfrom
reconnect-after-settled-preparation
Oct 10, 2026
Merged

SaladDay merged 1 commit into
mainfrom
reconnect-after-settled-preparation

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

When Runtime initialization returned unknown, ordinary disconnection kept retrying an already closed Router forever even after its apply and receipt workers had joined. Shutdown now permits reconnect after these workers finish, while preserving the unknown result and the old Router's admission fence. Core's persisted initialization failure still prevents setup replay and execution; workspace-write and native-executor cleanup keep their existing settlement checks.

Validation: dispatch, CLI, localworkspace and clirunner packages; preparation race tests repeated three times; affected vet; real PostgreSQL initialization cases covering reconnect after Worker restart without replay; English/Chinese translation checks. Shutdown regressions were red before the fix and green after it, including blocked apply and receipt delivery. Fresh independent review found no blocking issue. The native process checks cover the existing process-group/Job owner, not arbitrary escaped descendants or exactly-once external effects.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@SaladDay
SaladDay marked this pull request as ready for review October 10, 2026 19:22
@SaladDay
SaladDay merged commit 2bba238 into main Oct 10, 2026
22 checks passed
@SaladDay
SaladDay deleted the reconnect-after-settled-preparation branch October 10, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant