Repository navigation
Allow reconnect after settled initialization uncertainty - #658
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Runtime initialization returned
unknown, ordinary disconnection kept retrying an already closed Router forever even after its apply and receipt workers had joined. Shutdown now permits reconnect after these workers finish, while preserving the unknown result and the old Router's admission fence. Core's persisted initialization failure still prevents setup replay and execution; workspace-write and native-executor cleanup keep their existing settlement checks.Validation: dispatch, CLI, localworkspace and clirunner packages; preparation race tests repeated three times; affected vet; real PostgreSQL initialization cases covering reconnect after Worker restart without replay; English/Chinese translation checks. Shutdown regressions were red before the fix and green after it, including blocked apply and receipt delivery. Fresh independent review found no blocking issue. The native process checks cover the existing process-group/Job owner, not arbitrary escaped descendants or exactly-once external effects.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.