Repository navigation
Retain compute transition failure observations - #650
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an idle allocation commits a compute phase and a subsequent provider call fails, reconciliation was recording the failure against its earlier scan revision. The observation CAS correctly rejected that stale revision, leaving the actual failure invisible. Compute operations now carry the receipt they held when the failure occurred, so the existing typed diagnostic can be recorded against that exact allocation state and revision.
The private error wrapper preserves
errors.Is/errors.As. It never fetches a newer owner to attach an old failure, and delayed failures cannot overwrite a successor revision. No lifecycle state, public error, protocol or provider-specific behavior changes.Validation:
go vet, name guard and diff whitespace checks passed after rebasing on main.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.