Repository navigation
Doug's C++ refactoring review - #101
Open
d-torrance wants to merge 5 commits into
Open
d-torrance wants to merge 5 commits into
d-torrance wants to merge 5 commits into
Conversation
Review of e/unit-tests/NCGroebnerTest.cpp against STYLE.md and AGENTS.md, in PR4441-NCGroebner-review/. The -claude file is the full review written with Claude Opus 5.5; the -doug file is the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of the 13 files in the "Tests: other engine" unit (BRP-test.cpp through basics-test.cpp) against STYLE.md and AGENTS.md, in PR4441-other-engine-review/. The -claude file is the full review written with Claude Opus 5.5; the -doug file is the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Second-reviewer points not already in Anton's review, in PR4441-CC-CCC-review/. The -doug-claude file is the full review written with Claude Opus 5.5; the -doug file is the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rewritten MemoryBlock test writes values only after shrinkLastAllocate and never checks the address, so it can't catch the failure that F4's two callers depend on not happening. Add this as a point for the PR, and correct the "Good" entries, which said the test covered shrinking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All AI for now. Still awaiting human comments