Skip to content

fix(jp): address review regressions - #10

Merged
nichinichisou0609 merged 1 commit into
mainfrom
fix/pr7-review
Sep 29, 2026
Merged

nichinichisou0609 merged 1 commit into
mainfrom
fix/pr7-review

Conversation

@nichinichisou0609

Copy link
Copy Markdown
Collaborator

Summary

Follow up on #7 with the five confirmed review fixes:

  • Replay remote resources without opening or requiring the imported APK; validate the historical APK only when extracting an uncached local bundle or raw file.
  • Reuse bounded, process-local APKS/XAPK expansions. Invalidate changed archives, serialize first expansion, preserve active readers across eviction, and clean up failed expansions.
  • Use the explicitly selected region for web model/story APK preflight checks, including international regions.
  • Normalize documented schemeless API roots to HTTPS without relaxing origin or transport restrictions.
  • Let config check --json diagnose raw provider settings instead of failing during runtime default initialization.

Validation

  • 307 related synthetic Python tests passed, including the new regressions.
  • All six original review reproductions now pass; the unconfirmed bootstrap-version behavior is intentionally unchanged.
  • Pyflakes and git diff --check passed.
  • Rebased onto the merged feat(jp): support Japanese release assets and split APKs #7 commit; verified the rebase preserved the complete file tree.
  • No local Rust compilation, browser execution, or real-game-data batch processing was performed.

Merge

One focused patch commit; use the repository's enabled rebase-merge method. The already-merged feature commit remains unchanged.

🤖 Generated with Claude Code

Defer historical APK validation until a local resource cache miss, and
reuse bounded APKS/XAPK expansions without invalidating active readers.
Bind web preflight checks to the requested region, normalize schemeless
TLS API roots, and preserve raw settings for config-check diagnostics.

Add synthetic regressions for replay, archive lifetime and invalidation,
region selection, API origin restrictions, and diagnostic JSON output.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@nichinichisou0609
nichinichisou0609 merged commit 5f40d3e into main Sep 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant