Repository navigation
fix(hooks): prevent stale fallback swap and false onStatusChange on transient poll failure (#571) - #584
Open
Proxima84-code wants to merge 1 commit into
Conversation
…ransient poll failure (MergeFi#571)
|
@Proxima84-code is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #571.
In
useBountyStatus, mid-session polling was invokingfetchBounty(bountyId, fallbackBounty), which caught network errors and resolved withfallbackBountytagged assource: 'mock'. This causeduseSmartPollingto detect a false change (e.g. from liveclaimedback to initial fallbackopen), overwrite live state, fire falseonStatusChangeevents, and suppress error surfacing.Changes
src/lib/api.ts): ExportedfetchBountyLive(id)which propagates network/HTTP errors without intercepting them, while keepingfetchBounty(id, fallback)backwards-compatible for initial/SSR fallbacks.src/hooks/useBountyStatus.ts): Tracked whether live data has been observed (lastLiveBountyIdRef). Only fallback on initial load before any live data is received; once live data is established, network errors are rethrown souseSmartPollingsetserrorand preserves the live bounty status without firingonStatusChange.src/hooks/useBountyStatus.test.ts): Added unit tests covering:claimedstatus.claimedstatus, settingerror, and NOT emittingonStatusChange('open').