Repository navigation
fix(useSmartPolling): handle enabled state toggling and stabilize callback closures (#570) - #582
Open
PINYOPATTANAWASANPORN wants to merge 2 commits into
Conversation
|
@PINYOPATTANAWASANPORN is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
useSmartPollinglifecycle when togglingenableddynamically betweentrueandfalse(#570).fetchFn,compareFn, andonDataChangeoptions in stable React refs to prevent spurious interval teardowns on component re-renders (#568).setIntervaldynamically when exponential backoff scales interval (#569).src/hooks/useSmartPolling.test.ts.Root Cause / Technical Context
Previously,
useSmartPollingrelied on an unmanagedhasInitializedref guard and lacked state dispatches on disabled cleanup, which causedisPollingto remaintruewhen disabled and prevented interval restart when togglingenabledback totrue.Verification & Testing
enabled=true.enabledflips tofalse.enabledtoggles back totrue.