fix(hooks): update useSmartPolling to handle enabled toggle and reset isPolling (#570) - #578
Open
PINYOPATTANAWASANPORN wants to merge 2 commits into
Conversation
… isPolling (MergeFi#570) Ensure enabled=false dispatches STOP_POLLING and clears interval timer, and enabled=true correctly re-initializes active polling.
… isPolling (MergeFi#570) Ensure enabled=false dispatches STOP_POLLING and clears interval timer, and enabled=true correctly re-initializes active polling.
|
@PINYOPATTANAWASANPORN is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed a bug in
useSmartPollingwhere togglingenabledbetweentrueandfalseleftisPollingin a staletruestate when disabled, and failed to resume polling when re-enabled (#570).Root Cause / Technical Context
enabledtransitioned tofalse, the cleanup cleared the interval timer but omitteddispatch({ type: 'STOP_POLLING' }). Consequently,isPollingremainedtrueeven though polling had halted.enabledtransitioned back totrue,hasInitialized.currentwas already set totruefrom initial mount, causing the initialization branch to be skipped and preventing interval re-creation.isMountedRef.current = false) from theenabledlifecycle effect.STOP_POLLINGand clear the active interval timer whenenabled=false.START_POLLINGand start interval timer whenenabled=true.useRefto prevent infinite re-render loops.useSmartPolling.test.tsusing fake timers validatingenabled=true -> false -> truetoggling behavior.Verification & Testing
Ran
npx jest src/hooks/useSmartPolling.test.ts --coverage=false: