Skip to content

fix(maintenance-pool): reject contract's own address as sweep recipient #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rushikeshgarad2024-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(maintenance-pool): reject contract's own address as sweep recipient #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/maintenance-pool/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,10 @@ mod contract {
) -> Result<i128, Error> {
require_admin(&env)?.require_auth();

if recipient == env.current_contract_address() {
return Err(Error::InvalidTreasury);
}

let pkey = DataKey::Pool(pool_id);
let pool: MaintenancePool = env
.storage()
Expand Down
19 changes: 19 additions & 0 deletions contracts/maintenance-pool/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,3 +1060,22 @@ fn test_reclaim_deposit_requires_sponsor_auth() {
let err = client.try_reclaim_deposit(&303u64, &0u32, &sponsor);
assert!(err.is_err(), "reclaim_deposit must require the sponsor's own authorization");
}

#[test]
fn test_sweep_rejects_self_referential_recipient() {
let env = Env::default();
env.mock_all_auths();
let (_admin, _treasury, client) = setup(&env);

let token_admin = Address::generate(&env);
let (token_addr, asset_client, _token_client) = create_token(&env, &token_admin);
let sponsor = Address::generate(&env);
asset_client.mint(&sponsor, &1_000_0000000i128);

client.deposit(&304u64, &sponsor, &token_addr, &100_0000000i128);

let self_addr = client.address.clone();
let err = client.try_sweep(&304u64, &token_addr, &self_addr);
assert_eq!(err, Err(Ok(Error::InvalidTreasury)));
}