fix(bounties): replace read-then-save in expireOverdue with atomic status update guard (#460)

[PINYOPATTANAWASANPORN]

Summary of Changes

Fixed a concurrency race condition in BountiesService.expireOverdue() by replacing unconditional save() iterations with an atomic conditional status update guard (#460).

Root Cause / Technical Context

1. expireOverdue() previously fetched overdue bounties in OPEN, FUNDED, or CLAIMED status and then called bountyRepo.save(bounty) on each item.
2. If a concurrent operation transitioned a bounty to IN_REVIEW, MERGED, or PAID between getMany() and save(), save() overwrote the database row with EXPIRED, destroying the concurrent state transition without status re-checking.
3. Fix details:
   • Replaced bountyRepo.save(bounty) with bountyRepo.update({ id, status: In([OPEN, FUNDED, CLAIMED]) }, { status: EXPIRED }).
   • Updated unit test suite in bounties.service.spec.ts validating atomic update execution and return counts.

Verification & Testing

Ran npm test -- src/bounties/bounties.service.spec.ts:

PASS src/bounties/bounties.service.spec.ts
  BountiesService
    √ creates a bounty in OPEN status (12 ms)
    √ funding an OPEN bounty locks escrow and moves it to FUNDED (3 ms)
    √ threads the linked GitHub issue id and deadline into escrow.fund (#158) (2 ms)
    √ rejects funding a bounty that is already FUNDED (15 ms)
    √ rejects claiming a bounty that is still OPEN (not yet funded) (2 ms)
    √ claim moves FUNDED -> CLAIMED and records the contributor (1 ms)
    √ markMergedAndRelease releases escrow to the contributor and moves to PAID (2 ms)
    √ markMergedAndRelease batches user lookups for team splits (3 ms)
    √ refund calls escrowService.refund and moves bounty to REFUNDED (2 ms)
    √ refund skips escrow refund when no escrow is linked (2 ms)
    √ expireOverdue flips overdue bounties to EXPIRED via atomic update guard (#460) (2 ms)
    √ markPrClosedWithoutMerge transitions IN_REVIEW back to CLAIMED (1 ms)
    √ markPrClosedWithoutMerge rejects bounties not in IN_REVIEW (2 ms)
    √ lists bounties with repository and language filters (2 ms)

Test Suites: 1 passed, 1 total
Tests:       14 passed, 14 total
Snapshots:   0 total
Time:        1.65 s

[vercel]

@PINYOPATTANAWASANPORN is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.