Repository navigation
Feat/admin credentials pr limit - #19
Merged
Merged
Conversation
…update related prompts
There was a problem hiding this comment.
Pull request overview
This PR updates the admin credential management flows by lowering minimum password length requirements, adding a privileged admin credential reset path (intended for local/root recovery), and introducing automation to enforce a pull request size limit.
Changes:
- Reduce admin password minimum length from 12 to 6 across password change, bootstrap, and related UI/API messaging.
- Add
ResetAdminCredentialsto reset the single admin username/password without requiring the previous password, revoking existing sessions. - Add a GitHub Actions workflow to automatically close PRs exceeding 5,000 changed lines.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/server/general_api.go | Updates weak-password detection to match new 6-character minimum for password change responses. |
| internal/auth/service.go | Adds ResetAdminCredentials and reduces ChangePassword minimum length to 6. |
| internal/auth/service_test.go | Adds tests covering credential reset behavior (including session revocation) and input validation. |
| cmd/vocat/menu.go | Updates the root menu flow to reset admin credentials (including username) without asking for the current password. |
| cmd/vocat/menu_test.go | Adds tests ensuring credential reset prompts don’t request the current password and show current username. |
| cmd/vocat/bootstrap_admin.go | Lowers bootstrap password minimum length to 6. |
| .gitignore | Ignores /fix. |
| .github/workflows/pr-size-limit.yml | Adds workflow to enforce a 5,000 changed-line PR limit by closing oversized PRs and commenting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…als-pr-limit # Conflicts: # cmd/vocat/menu.go # internal/auth/service.go
MengMengCode
added a commit
that referenced
this pull request
Aug 15, 2026
* feat: reset admin credentials without requiring current password and update related prompts * feat: update password requirements to a minimum of 6 characters for admin credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.