Repository navigation
ci: update OFED version to doca3.3.4-26.01-2.0.0.0.719-0 - #3614
nvidia-ci-cd wants to merge 1 commit into
Conversation
Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
[Medium impact] The version change reaches OFED driver selection in examples and release configuration. Fix the webhook rejection and driver-check parser before merging. FindingsSummaryChanges the driver version to
Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.4-26...." · Reviewed by Greptile |
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-065000-0 | ||
| version: doca3.3.4-26.01-2.0.0.0.719-0 |
There was a problem hiding this comment.
Webhook rejects the new version
With webhook validation enabled, all seven changed example policies are rejected on spec.ofedDriver.version. The DOCA pattern in isValidOFEDVersion accepts four dot-separated numbers before the final dash, but 2.0.0.0.719-0 has five.
Extend the validator to accept this format and add a test for the exact new version before switching the examples.
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-065000-0 | ||
| version: doca3.3.4-26.01-2.0.0.0.719-0 |
There was a problem hiding this comment.
Driver check selects wrong manifest
Changing Mofed.version to doca3.3.4-… breaks make check-doca-drivers. The prefix-removal pattern in Makefile:483 requires the DOCA patch number to be 0, so it leaves this version unchanged. The next split sets DRIVERVERSION to doca3.3.4 instead of 26.01, causing the target to request the wrong release manifest.
Update the parser to accept nonzero patch numbers, or use the second dash-separated field as the release workflow already does.
Created by an internal DOCA CI job.