Repository navigation
feat: add Network Operator Grafana dashboard - #3593
Draft
almaslennikov wants to merge 2 commits into
Draft
almaslennikov wants to merge 2 commits into
almaslennikov wants to merge 2 commits into
Conversation
Provide an importable dashboard for component readiness, controller health, and optional host RDMA telemetry. Document scrape prerequisites, selector scope, and missing-data behavior. Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Contributor
[Low impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found. SummaryAdds an importable Grafana dashboard for Network Operator monitoring.
Grafana import and cluster behavior remain unverified, as noted in the PR description. Reviews (2) · Last reviewed commit: "fix: correct Grafana namespace and resta..." · Reviewed by Greptile |
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
almaslennikov
marked this pull request as draft
October 27, 2026 15:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1435.
Add an importable Grafana dashboard for component readiness, container restarts, controller reconciliation health, and optional host RDMA traffic/errors. Workload discovery supports release-specific and NicNodePolicy-generated names. The setup guide documents scrape prerequisites, single-cluster scope, separate job/namespace selectors, and missing-data semantics.
Validation: all 24 PromQL fixture checks passed with promtool 3.2.1, covering expected values, unrelated-job isolation, and absent metrics. JSON parsing, unique panel IDs, and git diff --check passed. Metric names and labels were checked against kube-state-metrics, the pinned controller-runtime source, and node exporter. No Go or deployment behavior changes.
Grafana runtime import and hardware/cluster validation remain unverified: local Docker containers stayed in Created, preventing the Grafana API check.
Design review requested (draft)
This introduces the dashboard's metric and user-facing interpretation contract. Please review these choices before marking ready:
Ready after maintainers agree on the dashboard scope and query semantics, the pending Helm/KIND checks finish, and a Grafana import/render check or explicit reviewer acceptance of that remaining validation gap is recorded. The 24 PromQL fixture checks and static checks are recorded above; Grafana runtime import and cluster/hardware behavior remain unverified.