Repository navigation
ci: fix PR lookup in cleanup-ci-branches workflow - #3584
Merged
Merged
Conversation
The PR lookup passed `--arg` to `gh api`, which is not a supported flag. Every call failed, and because stderr was discarded and the exit code ignored, every branch was reported as "No PR found" and skipped. No branch was ever deleted. Drop `--arg` and the client-side `head.ref` filter. The `head=owner:branch` query parameter already limits results to the branch, and the newest PR comes first. Stop suppressing errors so that API failures fail the job. Signed-off-by: Fred Rolland <frolland@nvidia.com>
Contributor
 [Medium impact] The PR appears safe to merge. SummaryFixes PR lookup in
No actionable issues found. Author Reviews (1) · Last reviewed commit: "ci: fix PR lookup in cleanup-ci-branches..." · Reviewed by Greptile |
almaslennikov
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR lookup passed
--argtogh api, which is not a supported flag. Every call failed, and because stderr was discarded and the exit code ignored, every branch was reported as "No PR found" and skipped. No branch was ever deleted.Drop
--argand the client-sidehead.reffilter. Thehead=owner:branchquery parameter already limits results to the branch, and the newest PR comes first. Stop suppressing errors so that API failures fail the job.