Repository navigation
ci: update OFED version to doca3.3.1-26.01-2.0.0.0.506-0 - #3581
nvidia-ci-cd wants to merge 1 commit into
Conversation
Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
[Medium impact] The change reaches OFED release defaults and example cluster policies. Fix the policy validator before merging; it rejects the new driver version in every updated example. FindingsSummaryChanges the DOCA driver version from
Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.1-26...." · Reviewed by Greptile |
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-059000-0 | ||
| version: doca3.3.1-26.01-2.0.0.0.506-0 |
There was a problem hiding this comment.
With policy validation enabled, the webhook rejects this version in all seven updated examples. isValidOFEDVersion accepts four dot-separated build numbers before the final hyphen, but 2.0.0.0.506-0 has five. Kubernetes therefore rejects spec.ofedDriver.version before the operator can deploy the driver. Extend the validator to accept this format and add a regression test alongside the version bump.
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-059000-0 | ||
| version: doca3.3.1-26.01-2.0.0.0.506-0 |
There was a problem hiding this comment.
Driver check selects wrong file
The new doca3.3.1 prefix breaks version extraction in make check-doca-drivers. The expression at Makefile:483 only strips prefixes ending in .0-, so DRIVERVERSION becomes doca3.3.1 rather than 26.01. Developers running the check now request release_manifests/doca3.3.1.yaml instead of the intended release_manifests/26.01.yaml. Update the extraction to support nonzero patch versions alongside this bump.
Created by an internal DOCA CI job.