Skip to content

ci: update OFED version to doca3.3.1-26.01-2.0.0.0.506-0 - #3581

Closed
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.506-0
Closed

nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.506-0

Conversation

@nvidia-ci-cd

Copy link
Copy Markdown
Collaborator

Created by an internal DOCA CI job.

Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change reaches OFED release defaults and example cluster policies.

Fix the policy validator before merging; it rejects the new driver version in every updated example.

Findings

  1. P1 Updated policies are rejected ▶
  2. P2 Driver check selects wrong file ▶

Summary

Changes the DOCA driver version from doca3.6.0-26.10-059000-0 to doca3.3.1-26.01-2.0.0.0.506-0.

  • OFED release defaults and example policies use the new driver version.

Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.1-26...." · Reviewed by Greptile

image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-059000-0
version: doca3.3.1-26.01-2.0.0.0.506-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Updated policies are rejected

With policy validation enabled, the webhook rejects this version in all seven updated examples. isValidOFEDVersion accepts four dot-separated build numbers before the final hyphen, but 2.0.0.0.506-0 has five. Kubernetes therefore rejects spec.ofedDriver.version before the operator can deploy the driver. Extend the validator to accept this format and add a regression test alongside the version bump.

Comment thread hack/release.yaml
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-059000-0
version: doca3.3.1-26.01-2.0.0.0.506-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Driver check selects wrong file

The new doca3.3.1 prefix breaks version extraction in make check-doca-drivers. The expression at Makefile:483 only strips prefixes ending in .0-, so DRIVERVERSION becomes doca3.3.1 rather than 26.01. Developers running the check now request release_manifests/doca3.3.1.yaml instead of the intended release_manifests/26.01.yaml. Update the extraction to support nonzero patch versions alongside this bump.

@rollandf rollandf closed this Oct 25, 2026
@github-actions
github-actions Bot deleted the ci/update-ofed-version-26.01-2.0.0.0.506-0 branch October 27, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants