Repository navigation
ci: update OFED version to doca3.3.3-26.01-2.0.0.0.632-0 - #3574
nvidia-ci-cd wants to merge 1 commit into
Conversation
Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
[Medium impact] The change reaches OFED driver version choices in release settings and sample policies. Fix the version validator and driver-check parser before merging. FindingsSummaryChanges the driver version from
Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.3-26...." · Reviewed by Greptile |
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-059000-0 | ||
| version: doca3.3.3-26.01-2.0.0.0.632-0 |
There was a problem hiding this comment.
With the operator's admission controller enabled, all seven updated examples are rejected. isValidOFEDVersion accepts four dotted build components followed by a dash, or at least six consecutive digits. The new tag has five dotted components (2.0.0.0.632), so it fails both branches. Update the validator and its tests to accept this format alongside the version change.
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-059000-0 | ||
| version: doca3.3.3-26.01-2.0.0.0.632-0 |
There was a problem hiding this comment.
Driver check selects wrong release
The new doca3.3.3 prefix breaks make check-doca-drivers. Its parser only strips a DOCA prefix ending in .0, so it now sets DRIVERVERSION to doca3.3.3 and requests doca3.3.3.yaml instead of 26.01.yaml. Update that parser to handle nonzero patch versions alongside this change.
Created by an internal DOCA CI job.