Skip to content

ci: update OFED version to doca3.3.3-26.01-2.0.0.0.632-0 - #3574

Closed
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.632-0
Closed

nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.632-0

Conversation

@nvidia-ci-cd

Copy link
Copy Markdown
Collaborator

Created by an internal DOCA CI job.

Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Medium impact] The change reaches OFED driver version choices in release settings and sample policies.

Fix the version validator and driver-check parser before merging.

Findings

  1. P1 New policies are rejected ▶
  2. P1 Driver check selects wrong release ▶

Summary

Changes the driver version from doca3.6.0-26.10-059000-0 to doca3.3.3-26.01-2.0.0.0.632-0.

  • Release settings and sample policies now use one OFED driver build.

Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.3-26...." · Reviewed by Greptile

image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-059000-0
version: doca3.3.3-26.01-2.0.0.0.632-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 New policies are rejected

With the operator's admission controller enabled, all seven updated examples are rejected. isValidOFEDVersion accepts four dotted build components followed by a dash, or at least six consecutive digits. The new tag has five dotted components (2.0.0.0.632), so it fails both branches. Update the validator and its tests to accept this format alongside the version change.

Comment thread hack/release.yaml
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-059000-0
version: doca3.3.3-26.01-2.0.0.0.632-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Driver check selects wrong release

The new doca3.3.3 prefix breaks make check-doca-drivers. Its parser only strips a DOCA prefix ending in .0, so it now sets DRIVERVERSION to doca3.3.3 and requests doca3.3.3.yaml instead of 26.01.yaml. Update that parser to handle nonzero patch versions alongside this change.

@rollandf rollandf closed this Oct 25, 2026
@github-actions
github-actions Bot deleted the ci/update-ofed-version-26.01-2.0.0.0.632-0 branch October 27, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants