Skip to content

ci: update OFED version to doca3.3.4-26.01-2.0.0.0.715-0 - #3571

Closed
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.715-0
Closed

nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.715-0

Conversation

@nvidia-ci-cd

Copy link
Copy Markdown
Collaborator

Created by an internal DOCA CI job.

Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change reaches OFED driver version selection in release settings and sample policies.

Fix the version checks before merging; the admission webhook rejects the updated policy examples.

Findings

  1. P1 New driver version is rejected ▶
  2. P2 Driver check requests wrong file ▶

Summary

Changes the driver version from doca3.6.0-26.10-059000-0 to doca3.3.4-26.01-2.0.0.0.715-0.

  • The release settings and sample policies now use the new OFED driver version.

Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.4-26...." · Reviewed by Greptile

Comment thread hack/release.yaml
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-059000-0
version: doca3.3.4-26.01-2.0.0.0.715-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 New driver version is rejected

With the admission webhook enabled, applying any updated example fails with invalid OFED version. isValidOFEDVersion accepts four dot-separated numbers before the final build number, or a six-digit build number. The new 2.0.0.0.715-0 suffix matches neither format. Extend the validator to accept this format and add a test alongside the version change.

Comment thread hack/release.yaml
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-059000-0
version: doca3.3.4-26.01-2.0.0.0.715-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Driver check requests wrong file

The nonzero patch version breaks make check-doca-drivers. Its prefix removal only matches doca<major>.<minor>.0-, so this tag leaves DRIVERVERSION as doca3.3.4 instead of 26.01. The target then requests the wrong release manifest and cannot check the driver. Update the prefix removal to accept nonzero patch versions.

@rollandf rollandf closed this Oct 25, 2026
@github-actions
github-actions Bot deleted the ci/update-ofed-version-26.01-2.0.0.0.715-0 branch October 27, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants