Repository navigation
ci: update OFED version to doca3.3.4-26.01-2.0.0.0.715-0 - #3571
nvidia-ci-cd wants to merge 1 commit into
Conversation
Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
[Medium impact] The change reaches OFED driver version selection in release settings and sample policies. Fix the version checks before merging; the admission webhook rejects the updated policy examples. FindingsSummaryChanges the driver version from
Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.4-26...." · Reviewed by Greptile |
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-059000-0 | ||
| version: doca3.3.4-26.01-2.0.0.0.715-0 |
There was a problem hiding this comment.
New driver version is rejected
With the admission webhook enabled, applying any updated example fails with invalid OFED version. isValidOFEDVersion accepts four dot-separated numbers before the final build number, or a six-digit build number. The new 2.0.0.0.715-0 suffix matches neither format. Extend the validator to accept this format and add a test alongside the version change.
| image: doca-driver | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| version: doca3.6.0-26.10-059000-0 | ||
| version: doca3.3.4-26.01-2.0.0.0.715-0 |
There was a problem hiding this comment.
Driver check requests wrong file
The nonzero patch version breaks make check-doca-drivers. Its prefix removal only matches doca<major>.<minor>.0-, so this tag leaves DRIVERVERSION as doca3.3.4 instead of 26.01. The target then requests the wrong release manifest and cannot check the driver. Update the prefix removal to accept nonzero patch versions.
Created by an internal DOCA CI job.