Skip to content

ci: update OFED version to doca3.3.3-26.01-2.0.0.0.630-0 - #3570

Closed
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.630-0
Closed

nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.630-0

Conversation

@nvidia-ci-cd

Copy link
Copy Markdown
Collaborator

Created by an internal DOCA CI job.

Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change reaches OFED driver selection in release defaults and sample policies.

Fix the version check before merging so users can apply the updated examples.

Findings

  1. P1 Updated examples are rejected ▶

Summary

Updates the driver version to doca3.3.3-26.01-2.0.0.0.630-0 in seven examples and both driver entries in hack/release.yaml.

  • OFED driver settings now use the doca3.3.3 driver tag.

Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.3-26...." · Reviewed by Greptile

image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-059000-0
version: doca3.3.3-26.01-2.0.0.0.630-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Updated examples are rejected

The new doca3.3.3-26.01-2.0.0.0.630-0 version does not match isValidOFEDVersion. Its DOCA pattern accepts exactly four dotted build-number parts or at least six consecutive digits; 2.0.0.0.630 matches neither. With validation enabled, creating or updating any of the seven changed examples fails with invalid OFED version, so users cannot deploy the driver from them. Extend the validator to accept this format and add a regression test alongside the version update.

@rollandf rollandf closed this Oct 25, 2026
@github-actions
github-actions Bot deleted the ci/update-ofed-version-26.01-2.0.0.0.630-0 branch October 27, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants