Repository navigation
Add PR checks for links, HTML validity and phone/desktop rendering - #7
Merged
Merged
Conversation
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mehran · project thread
Before: nothing checked a change before it went live. A wrongly capitalised image path works in a Windows preview but 404s on GitHub Pages, and you'd only find out on the live site.
After: every PR runs a "Site checks" GitHub Action. A red ✗ on the PR means something would break. The site itself doesn't change: no new scripts or dependencies are shipped to visitors.
What it checks
scripts/check_links.py, plain Python). It covers every localsrc/href/poster/srcset/data-full/CSSurl()on the live pages, and every sitemap entry. A live page missing from the sitemap is a warning. (Today that's Moondust, which PR Add Moondust to the sitemap and refresh lastmod dates #3 fixes.)html-validate(standard rules), over the live pages.scripts/check_pages.mjs). It flags sideways scrolling, JavaScript errors and local 404s. Problems fail the run only on pages the PR changes, or on every page whencss/orjs/changes. Elsewhere they show as warnings, so old issues don't block unrelated work."Live pages" means root pages without
noindex, plus404.htmland the three archive posts in the sitemap. The draft pages are skipped.Also in this PR
aria-labelon plain<div>s (footer social icons on every page, the documentary thumbnail strip) now hasrole="group", so screen readers actually announce the label.<h2>/<p>inside<span>(homepage photography cards, photogrammetry related-work cards) are now<div>s. Those wrappers were alreadydisplay: flexor absolutely positioned, so nothing moves.CLAUDE.mdexplains the checks and how to run them locally. The overview's backlog item 12 is updated, and there's a changelog line.How it was tested
Icons/…inabout.html) makes the link check fail. ChangingPStoComfy2026.htmlbefore its fix makes the render check fail with "scrolls sideways by 312px".Risks and follow-ups
checkout,setup-node). The npm tools (playwright,html-validate) are installed inside CI, pinned, and never shipped to the site.scripts/will be publicly reachable on the site, like every file in the repo. It's harmless.Suggestions
main.