Repository navigation
Say so when ComfyUI runs on the processor alone - #169
Merged
Merged
Conversation
Beta gate G3. A ComfyUI with no usable graphics card, started with --cpu or on a PyTorch build without GPU support, passed Check ComfyUI as if nothing were wrong, and every tool then took minutes per picture or failed. Worse, ComfyUI reports a CPU device's "vram_total" as the machine's system RAM (get_total_memory in model_management.py), and OpenLayer read it as VRAM: a 32 GB CPU-only machine was ranked as a workstation card, and VRAM limits and Setup's outlook were sized from it. isCpuOnlyComfy in hardwareAdvisor.ts is true when every reported device is type "cpu". A CPU device's memory is no longer returned as VRAM. Check ComfyUI, the first-run check and Find ComfyUI Active Port say "ComfyUI is online, but on CPU only." with the reason on the line below, and Detect Hardware reports No GPU. The note names the cause and what to check, not a list of usable tools, because nothing has been timed on a CPU-only ComfyUI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checked in Photoshop 2025 against a Comfy Desktop instance started with --cpu (ComfyUI 0.38.1 on port 8189) and a GPU ComfyUI 0.44.0 on 8188. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Photoshop checks, run by Claude on Mehran's machine (Photoshop 2025, dev build of this branch):
Two findings:
The G3 row in |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Beta gate G3. A ComfyUI with no usable graphics card passed Check ComfyUI as if nothing were wrong, and every tool then took minutes per picture or failed. That covers ComfyUI started with
--cpu, or a PyTorch build without GPU support.It was also worse than silent. ComfyUI reports a CPU device's
vram_totalas the machine's system RAM:get_total_memoryincomfy/model_management.pyreturnsvirtual_memory_total()for acpudevice, which I confirmed in the ComfyUI on disk. OpenLayer read that as VRAM, which had three effects:The fix:
isCpuOnlyComfy(systemStats)inhardwareAdvisor.tsis true when ComfyUI reports at least one device and every one is typecpu. Applempsand every GPU backend are not CPU.getPrimaryDeviceVramTotalBytesno longer returns a CPU device's memory, so the tier is unknown rather than workstation, and the VRAM limits fall back as they do when ComfyUI reports nothing.Why the note names no tools: the gate's wording asked for which tools will be too slow. I wrote the cause and what to check instead, because no tool has been timed on a CPU-only ComfyUI, and naming tools as usable would be a guess. The note follows the panel string rules: plain text, no
--, no backticks.A failed stats read can't fail the check: if
/system_statscan't be read, the check still succeeds without the warning.Verified
New
tests/comfy/cpuOnlyComfy.test.ts, 9 tests, built on the shape ComfyUI 0.37 reports for a CPU device:cuda,mps,xpuandprivateuseoneare not; an empty device list says nothing.Could NOT be verified
--cpuisn't my call. The gate row says this is still to do.What Mehran should check in Photoshop
Smoke checklist blocks (
docs/uxp-smoke-checklist.md):Load: UXP Developer Tool › OpenLayer › Reload.
--cpu, then Check ComfyUI. See: "ComfyUI is online, but on CPU only." with the reason underneath, and Detect Hardware reports No GPU.🤖 Generated with Claude Code