Repository navigation
chore: drop justification comments and let Verify release decide the release job - #157
Merged
Merged
Conversation
semantic-release posts PR comments after publishing; if that step fails the job failed even though the release exists, skipping app-store and homebrew-tap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from reviewing #149 and #151.
bluetoothQueue")connectPeripheral'srefreshStaleBondOnFailedOpendocs claimed every caller runs a name request; the page happens insideconnectPeripheral, and a leftover sentence referred to nothingcontinue-on-error: true, so a failure in semantic-release's post-publish comment step no longer fails the job when the release exists; "Verify release" still fails it when nothing was publishedNo code changes beyond comments and the workflow;
chore:/ci:commits do not cut a release.