Repository navigation
feat(site): add a history entry when a filter value is chosen, and restore the view on Back and Forward - #321
Merged
Merged
Conversation
…store the view on Back Choosing or clearing a value in a dropdown pushes an entry; typing in the search box or the entity bounds still rewrites the current one so a query is not one entry per keystroke. A popstate rebuilds the filters from the URL.
Mearman
force-pushed
the
feat/site-filters-history
branch
from
November 11, 2026 08:18
047e68c to
b3899d3
Compare
|
🎉 This PR is included in version 0.136.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choosing or clearing a value in a filter dropdown now adds a history entry, so Back returns to the view before the change and Forward re-applies it. A popstate rebuilds the filters from the address, and when the address already shows the view nothing is written, so Back and Forward do not push entries of their own.
Typing in the search box and the entity bounds still rewrites the current entry. Without that, one typed query would leave an entry per keystroke.
The e2e test picks a kind and expects one new entry, types a search and expects no more, then goes Back and expects the unfiltered view with the same count, and Forward and expects the kind and the search restored.