Repository navigation
feat(extract): the extraction window is an open sheet (#336) - #337
Merged
Merged
Conversation
The owner's pick of round 2 (B): no title and no caption, a large regular percentage with Cancel on the top row, a 12px recessed well as the bar, and one live line naming the member being written, fitted in the middle so its own name stays. Failed: "Couldn't extract" in the number's place, the well hatched where it stopped, the reason on the file line, Close on the accent fill. Every behaviour of the window is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
The file line rebuilt its ResizeObserver on every progress event, and a new observer fires on observe, so every tick was fitted twice with a style read each time. Now the observer lives as long as the window, skips its first call, and the font is read once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
# Conflicts: # CLAUDE.md # package-lock.json # package.json
# Conflicts: # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336.
The owner picked variant B, "Open sheet" (mockups:
research/prism/mockups/2026-10-09-extract-dialog/round2/index.html,overview.pngbeside it). Brief: "clean, fits every theme, minimal text": the bar, the percentage, one live line naming the file being extracted right now (WinRAR style), and Cancel.What changed
ExtractWindow: no title, no caption, no destination line. The archive is the box'stitleand itsaria-label("Extracting X to D" / "Couldn't extract X").%in--p-text-soft(blank until the engine speaks), Cancel at its end.--p-controlground,--p-dim2inset edge,--p-accent-solidfill, cornersvar(--p-radius). It is the widest and thickest thing in the window. The old pulse before the first number is gone (the well is simply empty, per the mockup).--p-dim. Fitted by a canvas measure in the MIDDLE so the member's own name is kept (fitPath, pure, unit-tested; replaces the character-countmiddleEllipsis). It is written in a layout effect and refits on resize or zoom. Main's existing 60ms progress cap (PROGRESS_EVERY_MS) keeps renders under one per frame, so no extra throttle was needed.--p-text) takes the number's place, the well keeps the fill where it stopped, hatched in--p-dim(the reducer now keepspcton failure), the file line is the reason alone (failureTextno longer repeats "That couldn't be extracted."), and Close is--p-sel-bgwith--p-on-accent.Tests
npm run typecheck: clean.npm run lint: 0 errors (7 existing warnings).npm test: 2657 passed, 2 skipped.extract(extract, extractWindow, extractCancel) all passed;zip =treeVerbs =drag(sevenZip, flatZip, zipMenus, zipWrites, zipProject, zipRestore, zipLocked, zipFolder, drag, treeVerbs) all passed.--p-controlwith an--p-accent-solidfill; padding 20/20; the file line is in the UI face; the cancelling state is caught at its commit (line says Cancelling, Cancel disabled at 0.5); the failure shows "Couldn't extract", the hatched stopped well, the reason alone, and Close on--p-sel-bg..e2e/shots/:extract-sheet-running-aurora.png,extract-sheet-running-sand.png,extract-sheet-failed-{aurora,sand,jade,midnight-hc}.png, plus the full-windowextract-window-running.pngandextract-window-error.png. Compared with the mockup's B; they match.Not machine-testable, for the hands-on pass: how the ticking file line reads zoomed in on a real large archive.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t