Repository navigation
Site: tip button after a web install; phone header sticky again - #45
Merged
Merged
Conversation
After the web installer finishes and its dialog closes, the install page shows the next step (join RecoveryGateway-Setup-XXXX, first-boot guide) and one optional tip line that opens the GitHub Sponsors / Ko-fi choice. The tip line appears at most once a month per browser; the note closes with a button. ESP Web Tools 10.4.0 has no completion event, so site.js reads its dialog's install state without changing it. Browser test with a stand-in dialog: hidden without a finished install, tip link, close, monthly limit, no overflow.
Owner: the tip link was easy to miss, and the phone header should follow the scroll. The note after a finished install now ends with a Ko-fi-style "Leave a tip" button (same support choice, still at most once a month). On phones the header is sticky again, opaque; the open menu fits the screen and scrolls inside, and closes on page scroll, a tap outside or Escape, so it cannot stay over the page heading. Anchored sections stop below the bar. Browser tests cover each behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecoveryGateway-Setup-XXXX, first-boot guide) and a Ko-fi-style Leave a tip button that opens the existing GitHub Sponsors / Ko-fi choice. Nothing appears before or without a finished install; the tip part shows at most once a month per browser; the note can be closed. ESP Web Tools 10.4.0 (vendored) has no completion event, so site.js reads its dialog's install state without changing it.Checked: site build, presentation, flasher, site browser (stand-in installer dialog; menu fit/scroll/outside/Escape; sticky header) and mobile installer tests.