fix: verify the development launcher before handoff - #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Make
pnpm devbuild and launch the intended checkout, then verify the actual process, profile and visible launcher before reporting success.--isolatedcreates a disposable profile;--profile PATHreuses one;--cached-onlyrefuses client downloads.Why
Selecting an absent
Electron.appthrough UI automation launches Electron's welcome page without loading gwonmac. Agents previously assembled the launch command and guessed readiness. The development command now owns the explicit app argument and profile assertion, and waits for the native window's show event before printinglauncher-open.Invariant
Bare Electron cannot produce a successful launcher receipt. An active profile refuses before building and is rechecked before launch, preserving its existing session. Build failure and invalid arguments cannot fall through to Electron startup.
Delivery
Target
main; no app release is needed. This changes development startup only. Packaged app behavior is unchanged. Existing worktrees must receive this change before they can use the new command; UI automation must still confirm the reported process exists before attaching.Verification
pnpm run check: passed all type, lint, link and unit/policy/UI checks (2,167 tests).Focused Electron tests: 2 passed in the final run, covering the real visible launcher, duplicate-profile refusal and bare-Electron rejection.
Actual
pnpm dev --isolated --cached-only: built, opened and verified the real launcher; the verification app and its disposable profile were cleaned up.An earlier command-level check exposed a DOM-ready/native-show race. The final implementation waits for the native show event, and the actual command plus both Electron regressions passed afterward.
Final documentation links and
git diff --check: passed. Full macOS Application verification is required before merge. No live gameplay claim.I kept this pull request focused.
I ran the relevant checks.
I did not add game binaries, credentials, diagnostics, or private traffic.
I updated documentation when behavior or an invariant changed.