Improve MetadataService logging#765
Draft
MasterKale wants to merge 6 commits into
Draft
Conversation
Owner
Author
|
Marking WIP for now until I write some tests. I'm otherwise happy with the current implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
loggerargument toMetadataService.initialize(). This argument is of typeSimpleWebAuthnLogger, which is a simple object of logging methods:The intention is that projects using SimpleWebAuthn can define an instance of this
interfacethat logs the message and arbitrary arguments in a way that makes sense for that project. This eliminates any SimpleWebAuthn-specific logging concerns that led to the old implementation getting ripped out of this project.Right now only
MetadataServicewill make use of this new logging pattern.Fixes #751