Repository navigation
Gate required beginner flow on release smokes - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the already-required
beginner-flowcheck depend on both release-readiness smoke jobs.The repository ruleset currently requires:
beginner-flow;It does not yet directly require:
package-smoke;contributor-smoke.The available repository connection cannot edit the administrative ruleset, so this PR makes the existing required
beginner-flowcheck fail unless both release smokes completed successfully.Behaviour
beginner-flownow:package-smokeandcontributor-smoke;success;This means a failed package/contributor smoke can no longer coexist with a green required
beginner-flow.Scope
CI/release protection only.
No runtime, parser, Evidence, installer, profile, bundle or submission behaviour changes.