Repository navigation
Make installer recover safely from stale virtualenvs - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make repeated beginner installations/upgrades safer when a checkout already contains a stale or broken
.venv.Previously,
install.shreused any existing.venvdirectory without validating the interpreter or pip inside it. That could turn an otherwise valid host Python setup into a confusing pip/bootstrap failure.Behaviour
The installer now:
.venv;.venv;.venv;.venvthat does not containpyvenv.cfg.Unknown files are therefore never deleted automatically.
Runtime data such as
data/, collected Evidence and contexts is not part of the repair path.Beginner-flow coverage
CI now verifies that:
data/content survives that repair;.venvdirectory is rejected and its marker file remains untouched;Documentation
The install guide now explains safe reinstall/upgrade behaviour and what happens when
.venvis damaged or unexpected.Scope
Installer and beginner UX only.
No parser, Evidence, profile, bundle, submission or heating-system behaviour changes.