Repository navigation
Preserve existing thread folders when changing the default workspace - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the default ACP workspace currently prevents existing conversations from resuming, because every load uses the new folder and the configuration binding changes. Persist a workspace per conversation so new conversations use the new default while existing sessions, delivery checks, approvals and pending follow-ups retain their original folder.
Existing journals are pinned to the current default on first startup. Operators must upgrade with the old configuration before changing that default; the documented migration preserves session IDs and never replays messages. Other authority, audience and harness changes retain their existing checks.
Validation: pinned Nix fmt, warnings-denied all-feature/all-target Clippy, and all 93 offline tests pass on macOS and Ubuntu. New fixtures exercise actual ACP new/load folders in both audience modes, restart persistence, legacy-journal migration, and rejection after unrelated harness changes. Ubuntu release build passed. No real Matrix or model calls are part of the fixtures.