Repository navigation
Use canonical Maple PCR histories in both SDKs - #891
Merged
Merged
Conversation
Contributor
|
Maple development preview: https://2f960970.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both SDKs currently fetch signed PCR histories from the legacy backend repository. Switch their production and development defaults to
MaplePrivacyLabs/Maple/master/services/opensecret/, where the backend import now maintains the same files.The verification key, embedded PCR0 roots, environment separation, custom URL overrides, caching, bounds, and redirect rejection remain unchanged. Keep the legacy repository's existing URLs and manual signed-file mirror for installed clients. This PR changes source defaults; it does not publish packages or deploy the backend.
Validation:
79385743c0a4e17d0f06a4a5fcf8240256448574; all 290 existing PCR0 signatures verified.The branch now incorporates merged PR #892, which patches fast-uri and corrects SDK workflow failure propagation, and PR #889, the backend Nix fixture fix. The diff against master remains the seven-file PCR URL/documentation change. The combined tree passed all nine root flake checks, TypeScript formatting/build and 123 tests (3 hosted tests skipped), and the normal Research build/818-test commit gate.
A fresh audit now reports GHSA-2883-xcg3-v3hh in the unchanged
eslint -> @eslint/eslintrc -> js-yaml@4.3.1development-tool chain. This advisory entered GitHub's database on 2026-09-08 at 21:24 UTC and was not reported in the earlier green SDK job. The current lockfiles match master; this PCR change does not introduce the dependency. Independent dependency-closure review found no js-yaml in the SDK or Research production closures. The audit remains enforced and fails until the separate dependency follow-up patches it. Functional validation after that failed audit was run separately; it is not a clean-audit claim.The original hosted run passed Research desktop builds and SDK integration; its only job failure was the unchanged Agent macOS subprocess fixture's 0.5-second deadline. The user explicitly accepted that Agent failure for this merge and requested a separate follow-up PR next round. Refreshed/full post-merge hosted builds are separate from the local validation above.