Repository navigation
test(agent): compare the quiet-shell cwd against the canonical folder - #1398
Merged
Merged
Conversation
The session stores its project root canonicalized, so on macOS a tempdir under /tmp reports /private/tmp. The assertion compared against the raw tempdir path and failed on every agent-full-macos run since #1378. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly failure in issue #1390.
What broke
quiet_shell_reports_effective_folder_deadline_and_idle_time_until_stop(added in #1378) fails on everyagent-full-macosrun since that PR merged. It's not flaky: it fails on every master push from 3c3bb67 through 95cb454, and in the 10-30 scheduled run.The session stores its project root canonicalized, so the shell-progress
cwdis the real folder (/private/tmp/...on macOS). The test compared it against the raw tempdir path. The test next to it in the same file already canonicalizes both sides. This PR does the same; the product code doesn't change.It slipped through because
agent-full-macosdoesn't run on PRs, only on master pushes and the nightly run.Verification (local, macOS, agent nix shell)
TMPDIR=/tmp/...:cargo test -p maple-agent --lib quiet_shell_reportsfails with the same/private/tmpvs/tmpdiff.cargo test -p maple-agent --lib shell_testspasses 2/2 with bothTMPDIR=/tmp/...and the default nix TMPDIR.cargo fmt --all -- --checkis clean, and the pre-commit hook passes.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.