Repository navigation
fix(agent-updates): allow bounded slow artifact downloads - #1385
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qualified Agent artifact downloads can fail before integrity verification on a valid slow connection: producer ZIPs had a 180-second deadline, while publication-stage ZIPs already allowed 900 seconds. The current 70.8 MB macOS artifact transfers at about 235 KiB/s and needs approximately five minutes. Three incomplete transfers were retained; none was extracted or accepted.
Use the same finite 900-second transfer budget for producer and stage downloads. Convert a subprocess timeout into a concise operator refusal while keeping the partial archive. There is no automatic retry or overwrite, and timeout failures produce neither extraction nor a success receipt.
Artifact size limits, exact IDs/ZIP digests, archive validation, source/provenance binding, independent attestations, signature verification, and protected publication approvals are unchanged. This changes the reusable operator only; it does not rebuild or change the already qualified Agent application packages.
Validation:
agent-updateslane passed, including publisher/Worker checks and a local deployment dry run.repolane passed all six root flake checks on macOS.git diff --checkpassed.Need help on this PR? Tag
@codesmith-botwith what you need.