Skip to content

fix(agent-updates): allow bounded slow artifact downloads - #1385

Merged
AnthonyRonning merged 1 commit into
masterfrom
codex-release-download-timeout
Oct 30, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
codex-release-download-timeout

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Qualified Agent artifact downloads can fail before integrity verification on a valid slow connection: producer ZIPs had a 180-second deadline, while publication-stage ZIPs already allowed 900 seconds. The current 70.8 MB macOS artifact transfers at about 235 KiB/s and needs approximately five minutes. Three incomplete transfers were retained; none was extracted or accepted.

Use the same finite 900-second transfer budget for producer and stage downloads. Convert a subprocess timeout into a concise operator refusal while keeping the partial archive. There is no automatic retry or overwrite, and timeout failures produce neither extraction nor a success receipt.

Artifact size limits, exact IDs/ZIP digests, archive validation, source/provenance binding, independent attestations, signature verification, and protected publication approvals are unchanged. This changes the reusable operator only; it does not rebuild or change the already qualified Agent application packages.

Validation:

  • 18 offline download-helper tests passed, including simulated 300-second success and over-900-second refusal with one request, preserved partial bytes, no extraction/receipt, and refusal to overwrite the partial file.
  • Existing agent-updates lane passed, including publisher/Worker checks and a local deployment dry run.
  • Existing repo lane passed all six root flake checks on macOS.
  • git diff --check passed.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@AnthonyRonning
AnthonyRonning merged commit 9a0ce48 into master Oct 30, 2026
21 checks passed
@AnthonyRonning
AnthonyRonning deleted the codex-release-download-timeout branch October 30, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant