Repository navigation
agent: add Fluent localization foundation - #1372
Draft
w3irdrobot wants to merge 2 commits into
Draft
w3irdrobot wants to merge 2 commits into
w3irdrobot wants to merge 2 commits into
Conversation
w3irdrobot
force-pushed
the
feat/agent-i18n
branch
from
October 30, 2026 16:42
ca02ff9 to
da4c255
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the first localization milestone: embedded Fluent catalogs, cached
tr/typedtr_argshelpers, OS locale resolution, and a host-persisted language selector. The update confirmation dialog is converted end to end, including its accessibility label. English is the only shipped catalog; this does not yet localize the whole app.Incorporates the feature-design review: language changes apply after quitting and reopening Maple, plain labels are cached, parameterized labels are formatted on state changes, and tests default to English. Catalog checks use the existing test lane. A current-behavior contract and agent guidance document what to extract and what to leave alone.
Rebased onto
master(56abe5e0) atda4c255e. The update dialog retains master's version-specific title through cached Fluent interpolation. Full localjust civalidation of the rebased head is running.Pre-rebase validation (Linux, 2026-10-30):
nix develop --no-update-lock-file -c just ciinapps/maple-agentpassed: formatting, metadata/packaging regressions, all four warning-denied Clippy configurations, dependency/SQLCipher checks, workspace tests, warning-denied all-target builds, and headless tests.nix flake check --no-update-lock-file --print-build-logspassed on x86_64-linux.7d6ecec0with the documentation-only reference cleanup later committed asca02ff94; implementation bytes were unchanged.No live service was used. Tests use disposable stores and GPUI's test harness. A real desktop smoke, non-English font/bidi rendering, and native macOS/Windows behavior have not been verified here. Native/tray menus, OAuth HTML, host errors, persisted timeline labels, date/money formatting, spell checking, and RTL support remain explicit follow-ups. Model prompts and user/generated content are outside UI translation.
Need help on this PR? Tag
@codesmith-botwith what you need.